From 1f8e939cf96e602ff901a33c8e99746fba5b9937 Mon Sep 17 00:00:00 2001
From: Gouvernathor <44340603+Gouvernathor@users.noreply.github.com>
Date: Sat, 6 Apr 2024 00:19:58 +0200
Subject: [PATCH] Improve some animations

not sure why the "on show, appear, start" was there when there's no "on hide", but it prevents animation from really doing its job
---
 game/scripts/animations/transforms.rpy                     | 7 ++++---
 .../scripts/characters/cho/events/quidditch/transforms.rpy | 6 ++++--
 game/scripts/constants.rpy                                 | 1 -
 game/scripts/interface/achievements.rpy                    | 5 +++--
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/game/scripts/animations/transforms.rpy b/game/scripts/animations/transforms.rpy
index 19657f26..568d6ded 100644
--- a/game/scripts/animations/transforms.rpy
+++ b/game/scripts/animations/transforms.rpy
@@ -61,8 +61,10 @@ transform blink_repeat:
     repeat
 
 transform bob(t=1):
-    on show, appear, start:
-        yoffset absolute(0)
+    animation
+    subpixel True
+    yoffset absolute(0)
+    block:
         ease t yoffset absolute(10)
         ease t yoffset absolute(0)
         repeat
@@ -155,4 +157,3 @@ init python:
         trans.xoffset = renpy.random.randint(-2, 2)
         trans.yoffset = renpy.random.randint(-2, 2)
         return clamp(1.0 - st, 0.05, 1.0)
-
diff --git a/game/scripts/characters/cho/events/quidditch/transforms.rpy b/game/scripts/characters/cho/events/quidditch/transforms.rpy
index fbc9c295..72261156 100644
--- a/game/scripts/characters/cho/events/quidditch/transforms.rpy
+++ b/game/scripts/characters/cho/events/quidditch/transforms.rpy
@@ -1,6 +1,8 @@
 transform sprite_fly_idle:
-    on show, appear, start:
-        yoffset absolute(110)
+    animation
+    subpixel True
+    yoffset absolute(110)
+    block:
         ease_back 2.5 yoffset absolute(90)
         ease_back 2.5 yoffset absolute(110)
         repeat
diff --git a/game/scripts/constants.rpy b/game/scripts/constants.rpy
index f85a3275..cf71f6ef 100644
--- a/game/scripts/constants.rpy
+++ b/game/scripts/constants.rpy
@@ -1,2 +1 @@
-
 define ALLOWED_CHARACTERS = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz "
diff --git a/game/scripts/interface/achievements.rpy b/game/scripts/interface/achievements.rpy
index 3e6f966c..4d24b556 100644
--- a/game/scripts/interface/achievements.rpy
+++ b/game/scripts/interface/achievements.rpy
@@ -173,8 +173,9 @@ screen achievement_window(msg="", title="", icon=None, xpos=0, ypos=60):
     timer 6.0 action Hide("achievement_window")
 
 transform rotate_circular(t=7):
-    on show, appear, start:
-        subpixel True
+    animation
+    subpixel True
+    block:
         rotate 0
         linear t rotate 360
         repeat