Commit Graph

708 Commits

Author SHA1 Message Date
a893892ecf Fix and simplify the map
in addition to benigh simplification, this actually fixes a bug : setting pos and align in the same line is a bug, it's always been unspecified, you should have been setting *anchor* instead. xycenter does that now.

(cherry picked from commit 48c4c4ecad44402bff76e3b4dbafeeda5424b6af)
2024-03-24 16:57:40 +00:00
2255d028e1 Remove unnecessary screen variable
(cherry picked from commit b222860bec0b6ed6f4210239a51c4c572c3e597d)
2024-03-24 16:57:03 +00:00
fd50b5d05a Save calling update_character_map_locations several times
(cherry picked from commit c64635aacea784e02c96b2565edf160ac450d842)
2024-03-24 16:56:51 +00:00
38fa26e5bf replace equivalent with statement
(cherry picked from commit ef62f74eedc1ba690544ba7eb4a1a901c1cb7c85)
2024-03-24 16:56:35 +00:00
066f007e63 Reform random map locations
the locations of the different characters aren't independant, but they weren't in the first place

(cherry picked from commit 9a3fe1df6538977ac4f44122b64574138422f119)
2024-03-24 16:51:27 +00:00
fb69dfa676 Use statements instead of equivalents
(cherry picked from commit 77e40301c9b8f15dc84d702d324ff3cf171d9057)
2024-03-24 16:50:52 +00:00
ff49d9fa95 Avoid circular reference
it clogs pickling and garbage-collecting

(cherry picked from commit 42f690f966d6993ffb3075021dceac97fb229147)
2024-03-24 16:49:22 +00:00
fe5a7402a9 No it doesn't
(cherry picked from commit 884c264f040765e8124bb997b313e989fe0b799f)
2024-03-24 16:48:49 +00:00
b34dc20901 Better text in screens
(cherry picked from commit 23a264c8f476a126ab4482a4394a4cb6422ed93b)
2024-03-24 16:48:21 +00:00
9ea4431f0e Auto-cleanup public variables
I chose not to add them directly in the screen, to keep it readable
but even though they're still global variables, now they are dynamic and cleaned as soon as we exit the menu

(cherry picked from commit 32cf1de3a0eaa901f2ba3df99589b6842d6a550b)
2024-03-24 16:39:50 +00:00
be9f071660 Clean most stats variables from the global store
(cherry picked from commit c493a4b9aa45ae4aa619a9edbb09bc0e5bea98b3)
2024-03-24 16:37:10 +00:00
202807e320 Fix genie reform
(cherry picked from commit 1618fc378ffcc3d8b76691ed3cf7acf6eb3b1200)
2024-03-24 16:36:29 +00:00
0a6b5e41df Use define for constants
(cherry picked from commit bbc1df1ea67e6fa2de6042f20153189470aa49b7)
2024-03-24 16:36:03 +00:00
c908f2e90b Further clean junk variable
(cherry picked from commit ca64492beba5aa37458c8118b90fe9d75e8511b6)
2024-03-24 16:35:37 +00:00
3a77f89fab Add style, clean junk variables
(cherry picked from commit 3d62c8b8181911572efa471f26906cbffe5b8ffd)
2024-03-24 16:35:23 +00:00
993b5c845a Simplify function
(cherry picked from commit bb2edc9a7bca99da2286b402aadad8b64a610335)
2024-03-24 16:35:13 +00:00
0e9dae05bd Use repr instead of manually added single quotes
(cherry picked from commit 2ccece1a3de0dc5595d4adf8b49fe4a681733d63)
2024-03-24 16:34:56 +00:00
4248f7f6d0 Improve ATL syntax
use the dedicated xycenter property
avoid setting the previous end-interpolation values before starting the new one, to avoid a jump if the player advances too quickly (also shortens the code)
add subpixel True, even though it doesn't seem very effective
prepare improvement in next renpy version

(cherry picked from commit 8b6627f588fc4a3049c77f5bf9bb0d18f2ec9d6e)
2024-03-24 16:31:08 +00:00
00da7e8855 Simplify generic CG code
(cherry picked from commit 40ddb2918515cee48114cdada4cdb79d6535db6f)
2024-03-24 16:30:26 +00:00
d7ba36baa8 Better animation
(cherry picked from commit aa95f701dc2cc372e31b119c5e935a90e9cd4a9b)
2024-03-24 16:30:03 +00:00
2a54c483e8 Simplify some code
(cherry picked from commit 641893217e8c52ee1dac4aedc097e300fa71e4f4)
2024-03-24 16:29:45 +00:00
4ee49a225b Reform genie layeredimage
(cherry picked from commit 3a429070fc8519900e02cec972363fe79f760825)
2024-03-24 16:27:26 +00:00
603990cf13 Repr instead of adding quotes
(cherry picked from commit 15e3e240fc29ae4003ac4b32c801f11f7af4f741)
2024-03-24 16:26:07 +00:00
97f0cef931 Simplify hide/show expression
(cherry picked from commit 9c274bee6f37cd44a86ec1267bb5f34859a83403)
2024-03-24 16:25:50 +00:00
40caec9428 Fix test call
it raised an exception in my case, and I'm fairly sure this is how it's supposed to work
also adds a complimentary hidden reset at the end

(cherry picked from commit eeb68cb6c67beb1f50b4ae98ea9510f55dd52802)
2024-03-24 16:25:06 +00:00
60479ad32d Avoid using reset_variables
(cherry picked from commit 2e17dd258223bdecbacbc415eb307fcc54ac2401)
2024-03-24 16:23:38 +00:00
094b010b7a Avoid using lists
(cherry picked from commit 78230893a8de70ea443e4e6730c0516fb651d4fb)
2024-03-24 16:22:53 +00:00
94404f4ed7 Use childful transforms as displayable
that's not *explicitly* documented, but it won't change any time soon
also deletes a placeholder image

(cherry picked from commit 3b6dd38e195b997d8f569957d87d657a28ddf54c)
2024-03-24 16:21:28 +00:00
3b4db03a6c Upgrade other uses of image manipulators
(cherry picked from commit a9dc1953793591578fe807e2aca551ab84509050)
2024-03-24 16:20:23 +00:00
0e4fccfa26 Modernize use of matrixcolor
(cherry picked from commit 985a0a79ede816783f2a0f59f238509013a3f25f)
2024-03-24 16:20:04 +00:00
fe0193cfc2 Hasten ConditionSwitch-es
(cherry picked from commit 9d52bd9c92edbd7525cfdb27a1d36437cdd6ac76)
2024-03-24 16:19:37 +00:00
0c564a521b Use expression instead of image
the only documented lingua
this is AST-equivalent

(cherry picked from commit 542db72609883b59d66f35db9178839d972288d7)
2024-03-24 16:19:01 +00:00
11047626e1 Factorize jumps in the elif
(cherry picked from commit 6dc1a048109f88a1b0c51a1ed3692fdfd69312d8)
2024-03-24 16:17:29 +00:00
67e589f47f Hasten elif chain
avoid reevaluating the choice equality

(cherry picked from commit 9b419fcbc3dce2238107cf4cb0fbbc5508df8584)
2024-03-24 16:17:14 +00:00
482969eaae Use renpy statement instead of python equivalent
(cherry picked from commit 976455bfc9f311439f655d6a737f4dd8032d314f)
2024-03-24 16:16:11 +00:00
5197b6a7a6 Use dynamic variable and condense menu-label syntax
The label is jumped to and not called, but the variable will still clean itself up eventually

(cherry picked from commit 4c52d1638faa4feef72fab92e3c8ff57c19e7272)
2024-03-24 16:16:01 +00:00
f941b77409 Convert ball_hint to a screen variable
no leak

(cherry picked from commit 4ec94d28f51389b901a11f16d9387d00670e599d)
2024-03-24 16:14:45 +00:00
415c90d11c Use the call screen statement in this case
this particular syntax is very precisely documented in the screens page

(cherry picked from commit f51f3a30a192f92361ae0e69ff7c8bc8a7fb7e14)
2024-03-24 16:13:58 +00:00
d3a2929b6c Better None syntax
(cherry picked from commit 8d4216a4768dfae2526a9347dcdb6f6507a9d206)
2024-03-24 16:13:32 +00:00
2110eeb92a Simpler inline conditional
(cherry picked from commit da636e93ab69a9553464a61b60644b820c2f85f2)
2024-03-24 16:12:53 +00:00
5ef4d4f2db Avoid extraneous bool call
(cherry picked from commit 6a4b56a182d7e46ecb2ad0bcbaa7828357589cce)
2024-03-24 16:12:42 +00:00
f1a0c779f6 Sort in-place to save time
(cherry picked from commit 36d3a5d1a79827a2c0f718fdf4124f61109a346c)
2024-03-24 16:12:30 +00:00
780c028eb3 Use python hide instead of a single-use function
(cherry picked from commit a606fc9ca264cff17755859c8323c00e1eee12b8)
2024-03-24 16:10:22 +00:00
12e2bbcfb6 Fix indent
(cherry picked from commit 925cf611c1c9bc3620b6a31448c7cfd56364dce2)
2024-03-24 16:10:00 +00:00
d9912ece6c Fix 15c998c 2024-03-24 16:09:16 +00:00
d48708579b Fix misuse of variable
- don't use a reserved name (starting with an underscore)
- use a file-local mangled name (starting with two underscores
- use renpy.dynamx to cleanup the variable automatically

(cherry picked from commit 3e86094b0b68321703bc6de21b95bf4c450715fb)
2024-03-24 16:00:53 +00:00
47b5184e06 Repr instead of adding simple quotes manually
it's a tad slower but it's a better general practice and we're in an error handling branch anyway

(cherry picked from commit e80bd9e6e697fd594db4b73644a15392a268ae55)
2024-03-24 15:55:25 +00:00
b60c87e9f8 Sirt in-place to save time
not the first time, so that we can still pass it iterators

(cherry picked from commit 21cb97b2e20c3f4cae346682b13e3bd208f57b6e)
2024-03-24 15:54:42 +00:00
36578fdd67 Simplify that call
(cherry picked from commit b21e179df00406feb676f1af9e55150958b25320)
2024-03-24 15:53:40 +00:00
200760471f skip unnecessary lambda
(cherry picked from commit 94a6f9302b21712f90b84bca8318559c789a55b5)
2024-03-24 15:53:19 +00:00