Commit Graph

660 Commits

Author SHA1 Message Date
48c4c4ecad Fix and simplify the map
in addition to benigh simplification, this actually fixes a bug : setting pos and align in the same line is a bug, it's always been unspecified, you should have been setting *anchor* instead. xycenter does that now.
2023-11-16 01:34:38 +01:00
b222860bec Remove unnecessary screen variable 2023-11-16 01:11:38 +01:00
c64635aace Save calling update_character_map_locations several times 2023-11-16 00:49:14 +01:00
ef62f74eed replace equivalent with statement 2023-11-16 00:14:04 +01:00
9a3fe1df65 Reform random map locations
the locations of the different characters aren't independant, but they weren't in the first place
2023-11-16 00:13:42 +01:00
77e40301c9 Use statements instead of equivalents 2023-11-15 23:47:24 +01:00
42f690f966 Avoid circular reference
it clogs pickling and garbage-collecting
2023-11-15 23:46:46 +01:00
884c264f04 No it doesn't 2023-11-15 23:41:29 +01:00
23a264c8f4 Better text in screens 2023-11-15 23:24:55 +01:00
32cf1de3a0 Auto-cleanup public variables
I chose not to add them directly in the screen, to keep it readable
but even though they're still global variables, now they are dynamic and cleaned as soon as we exit the menu
2023-11-15 23:06:04 +01:00
c493a4b9aa Clean most stats variables from the global store 2023-11-15 22:51:38 +01:00
1618fc378f Fix genie reform 2023-11-15 22:51:10 +01:00
bbc1df1ea6 Use define for constants 2023-11-15 21:34:14 +01:00
ca64492beb Further clean junk variable 2023-11-15 21:26:57 +01:00
3d62c8b818 Add style, clean junk variables 2023-11-15 21:25:10 +01:00
bb2edc9a7b Simplify function 2023-11-15 21:24:47 +01:00
2ccece1a3d Use repr instead of manually added single quotes 2023-11-15 20:54:03 +01:00
8b6627f588 Improve ATL syntax
use the dedicated xycenter property
avoid setting the previous end-interpolation values before starting the new one, to avoid a jump if the player advances too quickly (also shortens the code)
add subpixel True, even though it doesn't seem very effective
prepare improvement in next renpy version
2023-11-15 20:44:48 +01:00
40ddb29185 Simplify generic CG code 2023-11-15 20:44:46 +01:00
aa95f701dc Better animation 2023-11-15 20:44:44 +01:00
641893217e Simplify some code 2023-11-15 20:44:42 +01:00
3a429070fc Reform genie layeredimage 2023-11-15 20:44:39 +01:00
15e3e240fc Repr instead of adding quotes 2023-11-15 20:44:36 +01:00
9c274bee6f Simplify hide/show expression 2023-11-15 20:44:35 +01:00
eeb68cb6c6 Fix test call
it raised an exception in my case, and I'm fairly sure this is how it's supposed to work
also adds a complimentary hidden reset at the end
2023-11-15 20:44:33 +01:00
5460ec2572 Remove now-unused reset_variables relying on implem details
It is used in a txt draft which I didn't change, it can be done if deemed necessary
I think this function should be kept off, as it is both more dangerous and slower than the workarounds
2023-11-15 20:44:30 +01:00
2e17dd2582 Avoid using reset_variables 2023-11-15 20:43:34 +01:00
78230893a8 Avoid using lists 2023-11-15 20:43:32 +01:00
3b6dd38e19 Use childful transforms as displayable
that's not *explicitly* documented, but it won't change any time soon
also deletes a placeholder image
2023-11-15 20:43:30 +01:00
a9dc195379 Upgrade other uses of image manipulators 2023-11-15 20:43:28 +01:00
985a0a79ed Modernize use of matrixcolor 2023-11-15 20:43:25 +01:00
9d52bd9c92 Hasten ConditionSwitch-es 2023-11-15 20:43:23 +01:00
542db72609 Use expression instead of image
the only documented lingua
this is AST-equivalent
2023-11-15 20:43:20 +01:00
6dc1a04810 Factorize jumps in the elif 2023-11-15 20:43:18 +01:00
9b419fcbc3 Hasten elif chain
avoid reevaluating the choice equality
2023-11-15 20:43:15 +01:00
976455bfc9 Use renpy statement instead of python equivalent 2023-11-15 20:43:13 +01:00
4c52d1638f Use dynamic variable and condense menu-label syntax
The label is jumped to and not called, but the variable will still clean itself up eventually
2023-11-15 20:43:11 +01:00
4ec94d28f5 Convert ball_hint to a screen variable
no leak
2023-11-15 20:43:10 +01:00
f51f3a30a1 Use the call screen statement in this case
this particular syntax is very precisely documented in the screens page
2023-11-15 20:43:08 +01:00
8d4216a476 Better None syntax 2023-11-15 20:43:05 +01:00
da636e93ab Simpler inline conditional 2023-11-15 20:43:04 +01:00
6a4b56a182 Avoid extraneous bool call 2023-11-15 20:43:01 +01:00
36d3a5d1a7 Sort in-place to save time 2023-11-15 20:42:59 +01:00
a606fc9ca2 Use python hide instead of a single-use function 2023-11-15 20:42:57 +01:00
925cf611c1 Fix indent 2023-11-15 20:42:55 +01:00
15c998cd5a Weird variable setting 2023-11-15 20:42:52 +01:00
3e86094b0b Fix misuse of variable
- don't use a reserved name (starting with an underscore)
- use a file-local mangled name (starting with two underscores
- use renpy.dynamx to cleanup the variable automatically
2023-11-15 20:42:50 +01:00
e80bd9e6e6 Repr instead of adding simple quotes manually
it's a tad slower but it's a better general practice and we're in an error handling branch anyway
2023-11-15 20:42:48 +01:00
21cb97b2e2 Sirt in-place to save time
not the first time, so that we can still pass it iterators
2023-11-15 20:42:45 +01:00
b21e179df0 Simplify that call 2023-11-15 20:42:43 +01:00